Added Dns methods, Zone and ZoneTest. Fixes #596.#606
Added Dns methods, Zone and ZoneTest. Fixes #596.#606mderka merged 3 commits intogoogleapis:dns-alphafrom
Conversation
|
A general comment: does it make sense to merge this PR where |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Regarding the general comment, we had discussed it here before doing this. You are correct that it is in part redundant and we will be taking a step back by refactoring later, but it is in fact my preferred way. By taking this detour, I am getting a much better grasp of the library architecture, internals and style, which helps me a lot (I am still a newbie here). Plus, I am already almost done. Unless you feel really strongly about it, I still prefer to merge this PR and then refactor. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes #596.