Skip to content

Added Dns methods, Zone and ZoneTest. Fixes #596.#606

Merged
mderka merged 3 commits intogoogleapis:dns-alphafrom
mderka:dns-options
Feb 3, 2016
Merged

Added Dns methods, Zone and ZoneTest. Fixes #596.#606
mderka merged 3 commits intogoogleapis:dns-alphafrom
mderka:dns-options

Conversation

@mderka
Copy link

@mderka mderka commented Feb 2, 2016

Fixes #596.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 2, 2016
@mderka mderka added the api: dns Issues related to the Cloud DNS API. label Feb 2, 2016
@mziccard
Copy link
Contributor

mziccard commented Feb 2, 2016

A general comment: does it make sense to merge this PR where Zone and ZoneInfo are separate objects and then add a new one to merge them? I would prefer this to be done in one single PR if there are no strong arguments against.

This comment was marked as spam.

This comment was marked as spam.

@mderka
Copy link
Author

mderka commented Feb 2, 2016

Regarding the general comment, we had discussed it here before doing this. You are correct that it is in part redundant and we will be taking a step back by refactoring later, but it is in fact my preferred way. By taking this detour, I am getting a much better grasp of the library architecture, internals and style, which helps me a lot (I am still a newbie here). Plus, I am already almost done. Unless you feel really strongly about it, I still prefer to merge this PR and then refactor.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants